How can I efficiently get a players game passes and inventory?

YuuenS · 2024-05-27T14:05:29.070Z

I still can’t solve it :,c

Noah · 2024-05-29T00:59:02.538Z

Okay, can you clearly re-state your issue? I’m struggling to exactly understand what is going wrong.

YuuenS · 2024-05-29T02:01:20.095Z

I’ll try to explain myself better…

I recently followed a tutorial of “coolcapidog” about a “Pls Donate Kit” that he had created, I did all the steps well, and the only problem I had, was that the passes took a long time to load (in the logs that I left, it took 3 minutes to load) after I put this post, I could notice that the delay of the passes was due to the fact that in the module 31 (as shown in the logs) this module was verifying the “purchased passes” which in this case being a donation booth, it should not verify the purchased passes but it should verify the “created passes”.

The help I am asking for is to help me to modify the “MainModule” to prevent it from verifying the purchased passes, and thus improve the loading of the passes, which should take seconds to appear not minutes.

This is the kit

create.roblox.com

Creator Hub - Store

Discover millions of assets made by the Roblox community to accelerate any creation task.

And the videotutorial I left it in the message at the beginning of this post.

Noah · 2024-05-29T14:14:02.670Z

Okay, this is annoying. I do not have as many inventory items as you (You have 2780, I have 733.

Perhaps you are getting throttled by roproxy (Unlikely as their post says there is no rate limiting)? This would make sense as you would be sending 28 requests, you may also just be waiting for the pure compute time.

There might not be a super easy solution to reduce the waiting time

I’ve quickly whipped up this Python program to see how long everything takes:

timings.py

""""
A program designed to count the waiting time for roproxy.com

This program was not designed with efficiency in mind but rather replicating the MainModule used by the pls donate kit.

Get asset types: https://create.roblox.com/docs/reference/engine/enums/AssetType

"""
import time
import requests

startTime = time.time()
assetIds = [2, 11, 12, 34]
userId = 1012243713

def getItems(assetId):
    cursor = ""
    while True:
        request = requests.get(f"https://www.roproxy.com/users/inventory/list-json?assetTypeId={assetId}&cursor={cursor}&itemsPerPage=100&userId={userId}")
        requestJson = request.json()
        nextCusor = requestJson["Data"]["nextPageCursor"]
        if nextCusor == None:
            break
        else:
            cursor = nextCusor


for assetId in assetIds:
    getItems(assetId)
endTime = time.time()
finalTime = endTime - startTime
print(f"Time taken: {finalTime}")

After testing with your user ID (I think) time taken was 106 seconds, which is quite a long time to load in the assets for a single user, for me, it took 18 seconds, but of course, this is also too long.

The potential solution?

Perhaps, instead of waiting for all the data to be loaded before you add items, why not add items after each request?

Unfortunately due to the way that the main module is structured, this may quite a lot of code to be re-written.

I’ve attempted to re-write the module for you and it should work, heck, it’s not the best code for sure, but it should work. The data will add not sorted, but once all items are loaded, the items will be sorted but at least your stand has items.

MainModule.lua (Modified):

local module = {}
local dss = game:GetService("DataStoreService")
local http = game:GetService("HttpService")
local mps = game:GetService("MarketplaceService")
local mainStore = dss:GetDataStore("MainDataStore")

module.assetTypeIds = {
	["T-Shirt"]=2,
	["Shirt"]=11,
	["Pants"]=12,
	["Pass"]=34,
}

 module.getItems = function(assetId,plrId, stand, plr)
	local allItems = {}
	local createdByUser = {}
	local success, errormsg = pcall(function()
		local done = false
		local nextPageCursor
		while done == false do
			local data
			if nextPageCursor then
				data = http:GetAsync("https://www.roproxy.com/users/inventory/list-json?assetTypeId="..tostring(assetId).."&cursor="..nextPageCursor.."&itemsPerPage=100&userId="..tostring(plrId))
			else
				data = http:GetAsync("https://www.roproxy.com/users/inventory/list-json?assetTypeId="..tostring(assetId).."&cursor=&itemsPerPage=100&userId="..tostring(plrId))
			end
			if data then
				data = http:JSONDecode(data)
				local items = data["Data"]["Items"]
				for _, item in pairs(items) do
					table.insert(allItems, item)
					print(item["Item"]["Name"])
				end
				if data["Data"]["nextPageCursor"] then
					nextPageCursor = data["Data"]["nextPageCursor"]
					print(nextPageCursor)
				else
					done = true
				end
			else
				warn("No data.")
			end
			tempItems = {}
			for i, item in pairs(allItems) do
				pcall(function()
					if (item["Creator"]["Id"] == plrId) and (item["Product"]["IsForSale"] == true) then
						print("added item")
						table.insert(createdByUser,item)
						table.insert(tempItems, item)
					end
				end)
			end
			table.sort(tempItems, function(a, b)
				return a["Product"]["PriceInRobux"] < b["Product"]["PriceInRobux"]
			end)
			for _, item in pairs(tempItems) do
				if stand.ClaimedUserName.Value == plr.Name then
					local frame = script.Template:Clone()
					frame.ItemID.Value = item["Item"]["AssetId"]
					frame.Cost.Value = item["Product"]["PriceInRobux"]
					frame.ItemTypeId.Value = item["Item"]["AssetType"]
					frame.RobuxCost.Text = "$"..tostring(item["Product"]["PriceInRobux"])
					frame.Parent = stand.ItemsPart.Items.ScrollingFrame
				end
			end
		end
	end)
	return createdByUser
end

module.loadItems = function(stand, plr)
	for _, frame in pairs(stand.ItemsPart.Items.ScrollingFrame:GetChildren()) do
		if frame:IsA("Frame") then
			frame:Destroy()
		end
	end
	local tshirts = module.getItems(module.assetTypeIds["T-Shirt"],plr.UserId, stand, plr)
	local passes = module.getItems(module.assetTypeIds["Pass"],plr.UserId,stand, plr)
	local shirts = module.getItems(module.assetTypeIds["Shirt"],plr.UserId, stand, plr)
	local pants = module.getItems(module.assetTypeIds["Pants"],plr.UserId, stand, plr)
	print(#tshirts,"T-Shirts found.")
	print(#shirts,"Shirts found.")
	print(#pants,"Pants found.")
	print(#passes,"Passes found.")
	local allItems = {}
	local tble = {tshirts,passes,shirts,pants}
	for _, itemType in pairs(tble) do
		for _, item in pairs(itemType) do
			table.insert(allItems,item)
		end
	end
	--print("Total items found:",#allItems)
	table.sort(allItems, function(a, b)
		return a["Product"]["PriceInRobux"] < b["Product"]["PriceInRobux"]
	end)
	for _, frame in pairs(stand.ItemsPart.Items.ScrollingFrame:GetChildren()) do
		if frame:IsA("Frame") then
			frame:Destroy()
		end
	end
	for _, item in pairs(allItems) do
		if stand.ClaimedUserName.Value == plr.Name then
			local frame = script.Template:Clone()
			frame.ItemID.Value = item["Item"]["AssetId"]
			frame.Cost.Value = item["Product"]["PriceInRobux"]
			frame.ItemTypeId.Value = item["Item"]["AssetType"]
			frame.RobuxCost.Text = "$"..tostring(item["Product"]["PriceInRobux"])
			frame.Parent = stand.ItemsPart.Items.ScrollingFrame
		end
	end
end

module.clearStand = function(stand)
	--print("Clearing stand...")
	stand.SignPart.SurfaceGui.UserMessage.Text = "your text here"
	stand.Base.ClaimPrompt.Enabled = true
	stand.Base.ClaimedInfoDisplay.Enabled = false
	stand.Base.Unclaimed.Enabled = true
	stand.Claimed.Value = false
	stand.ClaimedUserName.Value = ""
	for _, frame in pairs(stand.ItemsPart.Items.ScrollingFrame:GetChildren()) do
		if frame:IsA("Frame") then
			frame:Destroy()
		end
	end
end

module.updateStandsEarned = function()
	for _, stand in pairs(game.Workspace.Stands:GetChildren()) do
		if stand.Claimed.Value == true then
			local plr = game.Players:FindFirstChild(stand.ClaimedUserName.Value)
			if plr then
				stand.Base.ClaimedInfoDisplay.UserRaised.Text = "R$"..tostring(plr.leaderstats.Raised.Value).." Raised"
			else
				--print("no player but claimed")
			end
		end
	end
end

module.findItem = function(itemID)
	for _, stand in pairs(game.Workspace.Stands:GetChildren()) do
		for _, frame in pairs(stand.ItemsPart.Items.ScrollingFrame:GetChildren()) do
			if frame:IsA("Frame") then
				if frame.ItemID.Value == itemID then
					return frame
				end
			end
		end
	end
end

return module

If this works, please mark as solution (this is deffo the longest scripting support response I’ve made ever (bleh) )

YuuenS · 2024-05-30T04:55:04.335Z

I tried the code but many passes were repeated, I don’t know why, couldn’t you remove the check of purchased passes? to check only the created passes?

Extra information:
The stands of the next kit, if the passes load faster (but not all), maybe that’s why it loads faster, but I’ve seen this same model in other donation games and my passes load normal, could you help me to see how the code of this KIT is created and see if with that information we can improve the MainModule of the first kit?

create.roblox.com

Creator Hub - Store

Discover millions of assets made by the Roblox community to accelerate any creation task.

Noah · 2024-05-30T11:29:49.428Z

YuuenS:

I don’t know why, couldn’t you remove the check of purchased passes? to check only the created passes?

Where is this being checked in the program?

YuuenS:

I tried the code but many passes were repeated,

Perhaps instead of loading all the assets they load just a couple, or perhaps they have API’s that cache?

YuuenS · 2024-05-30T13:38:04.961Z

Noah:

Perhaps instead of loading all the assets they load just a couple, or perhaps they have API’s that cache?

I just noticed that it uses the same API, it just loads faster because it doesn’t load all the passes, only 4 passes, but it’s weird because I have visited other donation games (other than Pls Donate) and in those games my passes load fine.

Noah · 2024-05-30T13:41:00.166Z

Yes, we should exclude pls donate from the equation as it’s likely a very well devleoped system. Perhaps there’s a better API call you can do to fetch items that are created by you?

~~Let me take a look.~~

Noah · 2024-05-30T13:47:15.917Z

This looks good.

https://inventory.roblox.com/v2/users/{userid}/inventory/{assettype}?limit={limit}

YuuenS · 2024-05-30T14:07:36.813Z

The console displays this

10:05:20.401   ▼ HttpService is not allowed to access ROBLOX resources (x4)  -  Servidor - MainModule:47
     10:05:20.402     HttpService is not allowed to access ROBLOX resources
     10:05:20.402     HttpService is not allowed to access ROBLOX resources
     10:05:20.402     HttpService is not allowed to access ROBLOX resources
  10:05:20.402  0 T-Shirts found.  -  Servidor - MainModule:75
  10:05:20.402  0 Shirts found.  -  Servidor - MainModule:76
  10:05:20.402  0 Pants found.  -  Servidor - MainModule:77
  10:05:20.402  0 Passes found.  -  Servidor - MainModule:78

Noah · 2024-05-30T14:14:45.024Z

Because you haven’t implemented it properly using roproxy, you’ll have to re-write the program to get this to work properly.

YuuenS · 2024-05-30T14:37:43.508Z

import time
import requests

startTime = time.time()
assetIds = [2, 11, 12, 34]
userId = 1928307387

def getItems(assetId):
    cursor = ""
    while True:
        request = requests.get(f"https://inventory.roblox.com/v2/users/{userId}/inventory/{assetId}?limit=100&cursor={cursor}")
        requestJson = request.json()
        nextCursor = requestJson.get("nextPageCursor")
        if nextCursor is None:
            break
        else:
            cursor = nextCursor

for assetId in assetIds:
    getItems(assetId)

endTime = time.time()
finalTime = endTime - startTime
print(f"Time taken: {finalTime}")

With this new API I got:
“Time taken: 4.353755474090576”

Much better than the previous one.

Noah · 2024-05-30T17:13:23.559Z

Sweeet, I presume we can mark this conversation as solved then?

YuuenS · 2024-05-31T00:33:16.881Z

No, because you still get the error “HttpService is not allowed to access ROBLOX resources” which means that you cannot use HttpService to access Roblox resources from within the Roblox environment itself. This is a security restriction imposed by Roblox to prevent abuse and protect user privacy.

So we will not be able to use that API

Noah · 2024-05-31T00:40:08.425Z

No, you can use this API, if you scroll up you can see:

Noah:

Because you haven’t implemented it properly using roproxy,

You can not make any requests to roblox.com from roblox studio, but you can use a proxy, replace roblox.com in the API request with roproxy.com.

YuuenS · 2024-05-31T01:29:03.263Z

How should the MainModule code look like then? :c

Noah · 2024-05-31T11:41:08.976Z

You’ll have to customise the code.

YuuenS · 2024-05-31T17:44:41.738Z

Can you help me do it?

Noah · 2024-06-01T01:19:48.892Z

Unfortunately I am unable to do this, it will simply take too much time that I do not have available.

system · 2024-06-08T01:20:12.044Z

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.